search

goerz / better-apidoc

A version of sphinx-apidoc with support for templating
BSD 2-Clause "Simplified" License
32 stars 6 forks source link

implicit namespace packages are missing in `subpackages` template variable #11

Open niosHD opened 6 years ago

niosHD commented 6 years ago

The sub package filter in the create_package_file function also removes implicit namespace packages (i.e., https://github.com/goerz/better-apidoc/blob/e1e4c59f709bb2f5d0b2a8f2515f9ad4e63a0bf2/better_apidoc.py#L453).

The issue is apparently already fixed in the upstream apidoc tool which performs the filtering using shall_skip (see https://github.com/sphinx-doc/sphinx/blob/b135e7ce4a919f73c04e376a14ce597b0f160cac/sphinx/ext/apidoc.py#L128-L129). Could you adopt this change into better-apidoc?

Furthermore, given that other changes like, for example, exclude support for shall_skip have been added upstream, I wonder if you plan to rebase better-apidoc on a more recent version of sphinx-apidoc in general.

goerz commented 6 years ago

Yes, I am planning to rebase on the latest version at some point, but I don't know yet when I'll get around to it.