search

goerz / gc3pie

Automatically exported from code.google.com/p/gc3pie
0 stars 0 forks source link

Conflicting remarks in source code #441

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
The source code for `OpenStackLrms.free()` shows these two
mutually-contradicting remarks:

    # FIXME: freeing the resource from the application is probably
    # not needed since instances are not persistent.

    # freeing the resource from the application is now needed as
    # the same instanc may run multiple applications

Is freeing the resource from the application needed or not?  And what
does it mean anyway?  Applications should not deal with backends.

This is the annotated version, with commit information::

    1fed5ce7 gc3pie/gc3libs/backends/ec2.py        (antonio.s.messina@gmail.com  2013-01-11 16:34:51 +0000 855)         # FIXME: freeing the resource from the application is probably
    1fed5ce7 gc3pie/gc3libs/backends/ec2.py        (antonio.s.messina@gmail.com  2013-01-11 16:34:51 +0000 856)         # not needed since instances are not persistent.
    1fed5ce7 gc3pie/gc3libs/backends/ec2.py        (antonio.s.messina@gmail.com  2013-01-11 16:34:51 +0000 857)
    b9880bbe gc3pie/gc3libs/backends/ec2.py        (antonio.s.messina@gmail.com  2013-02-01 15:52:54 +0000 858)         # freeing the resource from the application is now needed as
    b9880bbe gc3pie/gc3libs/backends/ec2.py        (antonio.s.messina@gmail.com  2013-02-01 15:52:54 +0000 859)         # the same instanc may run multiple applications

Original issue reported on code.google.com by riccardo.murri@gmail.com on 19 May 2014 at 3:53