search

goetas-webservices / wsdl-reader

Pure PHP WSDL reader
10 stars 17 forks source link

symfony event dispatcher >= 4.3 #9

Closed Nogrod closed 3 years ago

Nogrod commented 4 years ago

As of Symfony 4.3: Simpler event dispatching

Adds support for symfony 4.3 and newer, since older versions are unsupported now it should be published with a new major version like v1.0.0

jmikola/wildcard-event-dispatcher currently does not support the new event dispatcher, so for now removed and test skipped, PR created.

goetas commented 4 years ago

And how do we know that the library actually works if there are no tests running for the latest event dispatcher?

Nogrod commented 4 years ago

just the event test was disabled, added replacement until WildcardEventDispatcher is ready

goetas commented 4 years ago

thanks for your pr and apologies for the very late review.

unfortunatley i have to keep support for symfony 3.4, thus a compatibility layer with the old event dispatcher must be maintained. you can add a private method to do the dispatch and check the dispatcher type inside

tomasz-kusy commented 3 years ago

Hi, It have been done in https://github.com/goetas-webservices/wsdl-reader/pull/14

goetas commented 3 years ago

done in #14