goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.42k stars 152 forks source link

refactor(Switch): api improvements #103

Closed elite-benni closed 9 months ago

elite-benni commented 9 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

The api of the Helm component is very verbose and needs to use many components and directives. `

  Airplane mode
</label>`

Closes #

What is the new behavior?

The api of the helm part is now simplified. You only need to add the hlm-switch `

        Airplane mode
    </label>`

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

When using the helm component you have to change the api from:

<brn-switch hlm>
   <brn-switch-thumb hlm />
</brn-switch>

to:

 <hlm-switch />

you have to replace the brn component with the hlm-component.

Other information

elite-benni commented 9 months ago

Additional "breaking change" is that we now use display contents, wich caused the Switch to be displayed without gap in the card example, the gap was added manually in the example.