goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.29k stars 137 forks source link

feat(tabs): exposes new values in brn-tabs-trigger #104

Closed thatsamsonkid closed 8 months ago

thatsamsonkid commented 8 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

Brn Trigger currently does not expose the underlying elementRef as well as some other key values that could be useful in customizing the tabs component.

See this as an example of code used to create below tabs example

https://github.com/thatsamsonkid/portfolio-analog/blob/main/src/app/content/experience.component.ts#L199

Closes #

What is the new behavior?

PR update Brn trigger directive to expose underlying elementRef as well getters for key and if the tab is currently active.

Does this PR introduce a breaking change?

Other information

https://github.com/goetzrobin/spartan/assets/22568206/c8bdaa91-9af5-49fe-acea-c98510c329ef

goetzrobin commented 8 months ago

Also, @thatsamsonkid can you add the exposedAs for this issue: https://github.com/goetzrobin/spartan/issues/105? Thanks already!

goetzrobin commented 8 months ago

Also, @thatsamsonkid can you add the exposedAs for this issue: https://github.com/goetzrobin/spartan/issues/105? Thanks already!

thatsamsonkid commented 8 months ago

All sounds like good ideas to me, I'll make the changes later today