goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.42k stars 152 forks source link

fix(sheet): prevent sheet from triggering twice #108

Closed jstnjs closed 9 months ago

jstnjs commented 9 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

Opening the sheet will trigger twice, since we define the host element bindings in the sheet itself and also inherited it from the dialog.

Closes #102

What is the new behavior?

Host element bindings got removed and instead only inherited it from the dialog.

Does this PR introduce a breaking change?

Other information