chore(spinner): missing spinner stories added

Celtian commented 9 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[x] Other... Please describe: Missing storybook file added

Which package are you modifying?

[ ] accordion
[ ] alert
[ ] alert-dialog
[ ] aspect-ratio
[ ] avatar
[ ] badge
[ ] button
[ ] calendar
[ ] card
[ ] checkbox
[ ] collapsible
[ ] combobox
[ ] command
[ ] context-menu
[ ] data-table
[ ] date-picker
[ ] dialog
[ ] dropdown-menu
[ ] hover-card
[ ] input
[ ] label
[ ] menubar
[ ] navigation-menu
[ ] popover
[ ] progress
[ ] radio-group
[ ] scroll-area
[ ] select
[ ] separator
[ ] sheet
[ ] skeleton
[ ] slider
[x] spinner
[ ] switch
[ ] table
[ ] tabs
[ ] textarea
[ ] toast
[ ] toggle
[ ] tooltip
[ ] typography

What is the current behavior?

spinner is missing in storybook but it is implemented

What is the new behavior?

spinner is present in storybook

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

goetzrobin commented 9 months ago

Thanks for adding this! Spinner is kind of an artifact from the beginning of the project. However, since people seem to use it I think we should keep it! What do you think?

elite-benni commented 9 months ago

Yes, I think we should keep it. People are using it, so it adds value! I just was thinking, if we should also make it more public by adding a page for the spinner?

goetzrobin commented 9 months ago

@elite-benni I think that's a good idea!

goetzrobin / spartan