Closed thatsamsonkid closed 7 months ago
Oh no, you know I thought I remembered having kept that selector for hlm-accordion-item.directive. Shoot do we want to add it back? @goetzrobin @elite-benni I really meant to keep it none breaking
Haha all good! Let's add it back! Nothing's released yet 😃
Its already merged and we are in alpha ;) We do many breaking changes, while reworking the api. I don't think it is a problem, just wanted to point out that it is a breaking change.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Current hlm accordion api is this
What is the new behavior?
This PR simply expands on the above to provide a slightly simpler hlm api with the option to do something like the below. Looks a little cleaner and a little more consistent from a selector/tag perspective. But you can still continue to do either implementation depending on preference or use case
Does this PR introduce a breaking change?
Other information