goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.22k stars 133 forks source link

refactor(tabs): use input signals #158

Closed marcjulian closed 6 months ago

marcjulian commented 6 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

What is the new behavior?

Using input signal where possible. Also passing disabled prop correctly from hlmTabsTrigger to brnTabsTrigger.

Does this PR introduce a breaking change?

Other information

goetzrobin commented 6 months ago

Looks like the e2e tests failed @marcjulian. Can you take a look?

marcjulian commented 6 months ago

Looks like the arguments in storybook do not work with InputSignal yet. https://github.com/storybookjs/storybook/issues/25784

Type 'string' is not assignable to type 'InputSignal<BrnActivationMode, BrnActivationMode>'.

marcjulian commented 6 months ago

@goetzrobin seems to work now. What do you think?

marcjulian commented 6 months ago

I updated the comments about the remaining @inputs.