Closed theo-matzavinos closed 6 months ago
One thing I'd might change is the directives for the buttons to become:
hlmCarouselPrevious
andhlmCarouselNext
.
They're actually components which is why I opted for the kebab-case selector. I've borrowed this idea from material/cdk. I have no strong feelings about it though.
Some notes/questions:
Looking forward to your feedback.
One thing I'd might change is the directives for the buttons to become:
hlmCarouselPrevious
andhlmCarouselNext
.They're actually components which is why I opted for the kebab-case selector. I've borrowed this idea from material/cdk. I have no strong feelings about it though.
Some notes/questions:
- I didn't exactly follow shadcn's implementation and moved the scroll container to the root component. It was easier to implement this way especially since in shadcn they forward the classes to the inner div.
- Should I change the icons to lucide?
- There's really no logic since it's a helm component. Do we need to test anything?
Looking forward to your feedback.
Maybe we can add both selectors? You can have multiple selectors separated by a comma.
@theo-matzavinos Let me know if that gives you everything you need or if there's anything I can do to help you!
Maybe we can add both selectors? You can have multiple selectors separated by a comma.
That's reasonable. I should use the camelCase selectors in the docs then?
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #117
What is the new behavior?
Does this PR introduce a breaking change?
Other information