goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.36k stars 144 forks source link

Accordion not close automatically if it used in for loop #165

Closed akshata456 closed 7 months ago

akshata456 commented 7 months ago

Please provide the environment you discovered this bug in.

angular-storybook-demo.zip

Which area/package is the issue in?

accordion

Description

Check in the example of "Test" stories. you see data is loaded dynamically in the template, if you open the first accordion and then click on the second one, it opens the second accordion properly but does not close the first one. let me know if I missed something. thanks.

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

theo-matzavinos commented 7 months ago

<div hlmAccordion> should be outside the loop.

goetzrobin commented 7 months ago

This seems to use an older version of the primitives too, can you try upgrading to the newest version of the accordion?

akshata456 commented 7 months ago

@theo-matzavinos it works now. thanks.