search

goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.13k stars 123 forks source link

table: page size select options of data table preview isn't visible in darkmode #192

Closed danilolmc closed 3 months ago

danilolmc commented 4 months ago

Please provide the environment you discovered this bug in.

At table component preview page

Which area/package is the issue in?

Docs

Description

In dark mode, when attempting to select a page size for the data table, the selection options remain hidden due to the options having both a white background and white font color. The option value only becomes visible upon hovering.

Captura de Tela (44)

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

goetzrobin commented 4 months ago

Good catch! We should probably replace this with our new custom select component, which @thatsamsonkid finished the other day! Do you want to take a crack at it or should I take a look? @danilolmc

danilolmc commented 4 months ago

Thanks @goetzrobin!

Replacing it with the select component it's a good one. I can take a crack at it!

danilolmc commented 3 months ago

Fixed by #221