goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.13k stars 123 forks source link

select: ability to specify trigger template with any selector (not just hlm) #193

Open alexciesielski opened 4 months ago

alexciesielski commented 4 months ago

Which scope/s are relevant/related to the feature request?

select

Information

As already mentioned in Discord I rename all hlm selectors to my customer's prefixes, so the final HTML is consistent, in that all component use the customer's prefix.

Unfortunately there is a dependency of brn-select on hlm in the sense that the ng-content selects for a hlm-select-trigger, which means that it is not compatible with renamed triggers.

I'm pretty sure I am not the only one who will have the idea to fully customize the generated hlm content in their repository (I thought that's the whole point of being fully in charge of the final component logic), so my suggestions are:

  1. never depend/reference anything from hlm inside brn
  2. instead of using ng-content using @ContentChild that the consumers provide (solution as shown in Discord)

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue