goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.13k stars 123 forks source link

Property 'class' does not exist on type 'BrnColumnDefComponent' #196

Closed andrejsipka closed 3 months ago

andrejsipka commented 4 months ago

Please provide the environment you discovered this bug in.

`export class HlmThComponent { private readonly _columnDef? = inject(BrnColumnDefComponent, { optional: true }); protected readonly truncate = input(false, { transform: booleanAttribute });

public readonly userClass = input<ClassValue>('', { alias: 'class' });
protected readonly _computedClass = computed(() =>
    hlm(
        'flex flex-none h-12 px-4 text-sm items-center font-medium text-muted-foreground [&:has([role=checkbox])]:pr-0',
        this._columnDef?.class(),     **<======== Doesn't exist**
        this.userClass(),
    ),
);

}`

Which area/package is the issue in?

table

Description

After changing access modifier in the table component from private to public for useClass inputSignal, compiler encountered an error in both HlmThComponent and HlmTdComponent.

Please provide the exception or error you saw

TS2339: Property 'class' does not exist on type 'BrnColumnDefComponent'. [plugin angular-compiler]

Other information

No response

I would be willing to submit a PR to fix this issue

elite-benni commented 4 months ago

This should be fixed with #164.

marcus-sa commented 4 months ago

@elite-benni when will this be released?

elite-benni commented 4 months ago

the next release is planned for today, hopefully @goetzrobin finds the time to release it.

goetzrobin commented 4 months ago

@marcus-sa @andrejsipka this should be addressed now. Please let me know if this issue is resolved after you upgrade