peer dependency conflicts with clsx

goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.

https://spartan.ng

MIT License

1.13k stars 123 forks source link

peer dependency conflicts with clsx #207

Open dez1729 opened 4 months ago

dez1729 commented 4 months ago

Please provide the environment you discovered this bug in.

ui/core 0.0.1-alpha.336

Which area/package is the issue in?

Don't know / other

Description

It seems that the installed version of clsx which is 1.2.1 conflicts with the current version which is 2.1.0. As a result, any npm updates fail unless using --force.

Please provide the exception or error you saw

No response

Other information

No response

I would be willing to submit a PR to fix this issue

[ ] Yes
[X] No

goetzrobin commented 4 months ago

Hey @dez1729! Have you had clsx installed before or was it installed as part of the spartan CLI setup?

dez1729 commented 3 months ago

i installed clsx in my project separately which is the reason the conflict occurred. I would need it installed to use clsx on the installed spartan packages correct?

goetzrobin commented 3 months ago

yes. the CLI installs the correct version for you, but if your project already uses clsx then it might cause conflicts. Let me see what breaking changes were introduced and if it's a good idea for bumping up the version in general