goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.35k stars 143 forks source link

Data Table Component Preview - Pagination Dropdown theme issue #221

Closed ragul1697 closed 6 months ago

ragul1697 commented 6 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

For the Data Table pagination dropdown, the selection list UI does not match the system's current theme. It remains at light background when the dark theme is active.

Closes #

What is the new behavior?

The Data table page dropdown now matches with the system theme.

Does this PR introduce a breaking change?

Other information

elite-benni commented 6 months ago

Thanks for the PR. We were usually planning to replace the select with our new select component. Would you like to do this instead of setting the background?

ragul1697 commented 6 months ago

Sure, I will replace it with the select component.

ragul1697 commented 6 months ago

I have updated the Data Table pagination with the new Select component. There was an issue in the naming of Data Table Page component. It was named as ComboBoxComponent and fixed it also.

elite-benni commented 6 months ago

We also have some formatting problems here, please make sure to run prettier before pushing. ;) I would like to delay this PR until the select is fixed.

ragul1697 commented 6 months ago

@elite-benni Code Formatting is completed.

ragul1697 commented 6 months ago

@elite-benni I have completed the changes. Please have a look at the code. Thanks for your Time.