goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.1k stars 121 forks source link

Feature - making the image in The 300 clickable along with the text #226

Closed monacodelisa closed 1 month ago

monacodelisa commented 3 months ago

Which scope/s are relevant/related to the feature request?

Docs

Information

When I look at The 300 each contributor has the Spartan logo image and their username below only the username is clickable

image

the text is a bit tiny and I feel that it will a bit more user friendly if both the image and the text are wrapped up in the link element, so that clicking on either would navigate the user to the contributor's GitHub profile

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

thatsamsonkid commented 3 months ago

@monacodelisa - just wanted to double check if you planned on making this change yourself? Otherwise this could make a good first issue for someone.

monacodelisa commented 3 months ago

@thatsamsonkid sure, this one as well - maybe keep it open, and if no activity after a while, I can take it then.

mateoetchepare commented 3 months ago

i'll take the issue if you guys don't mind

mateoetchepare commented 2 months ago

sorry, i had a lot of trouble trying to run the development server bc i was on a windows machine, i justed fixed it by installing a debian VM. i promise in a few days i'll have the PR. thank you for your patience

monacodelisa commented 2 months ago

@mateoetchepare I also had some issues on windows, so Debian VM works ? That's good, I tried using github codespaces they also help because I no longer run into the Windows specific errors

mateoetchepare commented 2 months ago

yes, in debian everything is working fine right now. in windows i tried different versions in those specific packages and i couldn't fix the error

BoogieMonsta commented 1 month ago

@goetzrobin I believe this issue should be closed :)