goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.1k stars 121 forks source link

docs(data-table): it replaces native select by existing select component #233

Closed danilolmc closed 3 months ago

danilolmc commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

In dark mode, the data table page size select options only become visible upon hovering.

Closes #192

What is the new behavior?

In dark mode, the data table page size select options get the proper background color by using the existing select custom component

Does this PR introduce a breaking change?

elite-benni commented 3 months ago

This is a duplicate of #221. Thanks for contributing to the project. Most of your changes that Robin commented, are a workaround to the problem that select does not display the correct value if it is not a string. ;) Closing because of a duplicate.

danilolmc commented 3 months ago

Thanks @elite-benni!

I didn't found the original issue reference for de MR #221 so I closed the issue #192 as it is solved by #221 MR

elite-benni commented 3 months ago

Thanks for closing the issue.