goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.1k stars 121 forks source link

feat(select,spinner,separator,toggle): more input signals #235

Closed Celtian closed 3 months ago

Celtian commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

Other information

ajitzero commented 3 months ago

Hi, are you converting these manually? There is a reasonably stable CLI migration command for this.

Please take a look: https://twitter.com/Enea_Jahollari/status/1773335882780557471

npm i ngxtension
ng g ngxtension:convert-outputs
Celtian commented 3 months ago

Hi, are you converting these manually? There is a reasonably stable CLI migration command for this.

Please take a look: https://twitter.com/Enea_Jahollari/status/1773335882780557471

npm i ngxtension
ng g ngxtension:convert-outputs

But there is a problem. Compatibility with Storybook. You can's convert everything right now...

ajitzero commented 3 months ago

Ah, that makes sense! Thanks for the info, I hadn't tried it myself yet.

elite-benni commented 3 months ago

LGTM! Its just so much cleaner this way!