goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.1k stars 121 forks source link

refactor checkbox to use model input #244

Closed marcjulian closed 2 months ago

marcjulian commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

disabled without value used to work, now disabled needs a value, because model input does not have transform function.

<brn-checkbox 
- disabled 
+ disabled="true"
  id="checkboxId' 
  name="checkboxName">
</brn-checkbox>

This only applies to brn-checkbox, with hlm-checkbox it still works with just disabled because there we can use an input with transform.

Other information

marcjulian commented 2 months ago

@goetzrobin I changed the disabled input model to input with transform to avoid the breaking change.

goetzrobin commented 2 months ago

@marcjulian I see one merge conflict. Else this looks good to me!

marcjulian commented 2 months ago

@goetzrobin Merge conflicts resolved.