goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.1k stars 121 forks source link

docs: include authentication example to examples page #256

Closed danilolmc closed 1 month ago

danilolmc commented 3 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

The current examples page has very few examples showing what can be done using the spartan/ui library

Closes #241

What is the new behavior?

The examples page now gets an authentication example showcasing what can be done with spartan/ui, this is a starting point to add more examples to the page similar to shadcn/ui

Does this PR introduce a breaking change?

Other information

thatsamsonkid commented 1 month ago

Hi @danilolmc sorry I know this has been sitting for a while, was curious if you could rebase the branch so at least the checks can run again. I think you resolved all the previous comments so I'd be happy to see to getting this merged in

danilolmc commented 1 month ago

Hi @thatsamsonkid, no problem, I'm going to rebase the branch.

danilolmc commented 1 month ago

It's done @thatsamsonkid !

danilolmc commented 1 month ago

Thanks for your review @thatsamsonkid!

Now it's resolved!