goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.1k stars 121 forks source link

improve icon size type definition #258

Closed gergobergo closed 2 months ago

gergobergo commented 2 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

After the TS check the type of the ´iconSize´ was string export type IconSize = DefinedSizes | string;

so the DefinedSizes didn't make any difference.

What is the new behavior?

After the refactor the type still accepts any string, but the intelliSense will show the DefinedSizes values as a suggestion.

Does this PR introduce a breaking change?

Other information