feat(repo): fix build errors in nitropack and during server and static page rendering

goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.

https://spartan.ng

MIT License

1.09k stars 120 forks source link

Closed benpsnyder closed 1 day ago

benpsnyder commented 2 months ago

Completed:

[x] #275 -- Resolves sufficiently because this isn't something we have to worry about and we shouldn't see the console littered with deprecation messages. It will be resolved upstream with nitropack.
[x] #272 -- easily resolves by bumping the package version due to https://github.com/angular/cdk-builds/commit/b993db89f8368e2ddf97685b9d0dedbb2d8bde51 being addressed

WIP:

goetzrobin commented 2 months ago

@benpsnyder is this good to go?

goetzrobin commented 4 weeks ago

@benpsnyder is this still needed?

benpsnyder commented 4 weeks ago

Let me check on it by tomorrow; I will do some housecleaning in the repo here

goetzrobin commented 1 day ago

@benpsnyder I'll close this PR for now. Once you have the time and capacity to resolve the conflicts feel free to update and reopen!