goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.09k stars 120 forks source link

feat(button): add button type input #291

Closed marcjulian closed 1 month ago

marcjulian commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Which package are you modifying?

What is the current behavior?

# template
<button hlmBtn>Spartan!</button>

# rendered
<button hlmbtn class="...">Spartan!</button>

What is the new behavior?

# template
<button hlmBtn>Spartan!</button>

# rendered
<button hlmbtn type="button" class="...">Spartan!</button>

Does this PR introduce a breaking change?

Other information

marcjulian commented 1 month ago

I guess that was to quick. This should only be applied to an actual <button> element, however, hlmBtn could be applied to an a tag too.