search

goetzrobin / spartan

Cutting-edge tools powering Angular full-stack development.
https://spartan.ng
MIT License
1.09k stars 120 forks source link

feat(repo): move from pnpm to bun #295

Closed benpsnyder closed 1 day ago

benpsnyder commented 1 month ago

Work in progress (POC) Opening for feedback

benpsnyder commented 1 month ago

@brandonroberts could you comment on this? image

brandonroberts commented 1 month ago

Is this being imported on the server? Nitro needs to be configured to use tsconfig paths

https://github.com/analogjs/analog/issues/977#issuecomment-2025120729

benpsnyder commented 1 month ago

Is this being imported on the server? Nitro needs to be configured to use tsconfig paths

analogjs/analog#977 (comment)

I thought we solved that with https://github.com/goetzrobin/spartan/blob/main/apps/app/nitro.config.ts

benpsnyder commented 1 month ago

This works if you use pnpm. image

image

nx run-many --target=build --all

I am going to open an issue over in the Bun repo referencing this PR.

benpsnyder commented 1 month ago

OK it works if you remove workspaces from ./package.json (you need to delete node_modules and bun i fresh)

"workspaces": [
  "apps/**",
  "libs/**",
  "tools/**"
],

I don't fully understand why.

goetzrobin commented 1 day ago

@benpsnyder I'll close this PR for now. Once you have the time and capacity to resolve the conflicts feel free to update and reopen!