search

gofed / go-macros

Rpm mechanics for Go packaging
4 stars 7 forks source link

golist filters extensions incorrectly #45

Closed nim-nim closed 6 years ago

nim-nim commented 6 years ago

%goinstall -e y does not add just .y files, it also adds .py files

ingvagabund commented 6 years ago

Expected usage is %goinstall -e .y.

ingvagabund commented 6 years ago 
$ golist --help
NAME:
   golist - List Go project resources (built with Go ???)

USAGE:
   golist [global options] command [command options] [arguments...]

VERSION:
   0.0.1

COMMANDS:
     help, h  Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --ignore-dir value, -d value         Directory to ignore
   --ignore-tree value, -t value        Directory tree to ignore
   --ignore-regex value, -r value       Regex specified files/dirs to ignore
   --package-path value                 Package entry point
   --all-deps                           List imported packages including stdlib
   --provided                           List provided packages
   --imported                           List imported packages
   --skip-self                          Skip imported packages with the same --package-path
   --tests                              Apply the listing options over tests
   --show-main                          Including main files in listings
   --to-install                         List all resources recognized as essential part of the Go project
   --include-extension value, -e value  Include all files with the extension in the recognized resources, e.g. .proto, .tmpl
   --json                               Output as JSON artefact
   --help, -h                           show help
   --version, -v                        print the version

See --include-extension value, -e value Include all files with the extension in the recognized resources, e.g. .proto, .tmpl

nim-nim commented 6 years ago

It may be coded like this, but from a human interface POW it is terrible: the leading dot is not part of the extension, so forcing people to specify it is unexpected and redundant, and not specifying it seems to work, till you hit two extensions that end up with the same letters. It will cause lots of nasty unobvious and difficult to debug problems.