search

gofed / go-macros

Rpm mechanics for Go packaging
4 stars 7 forks source link

%{goname} should not be case insensitive / all lower case #49

Closed decathorpe closed 6 years ago

decathorpe commented 6 years ago

According to https://fedoraproject.org/wiki/Packaging:Naming#Case_Sensitivity, the upper/lower casing of the upstream project name (and, by extension, author / organization, in this case) should be respected.

Additionally, this also creates issues when converting old golang packages (which contain uppercase letters in the name) to the new macros.

nim-nim commented 6 years ago

fedora packaging guidelines have been updated to mandate lowercase

decathorpe commented 6 years ago

Well, not mandated exactly. The guidelines state:

Package names SHOULD be in lower case (...)

But I'm generally more concerned with packaging headaches caused by this. I recently converted all my golang packages to "spec 3.0", but for the packages where either the upstream project or repository have upper case letters in them I could not use the pre-filled (and convenient) %{goname} macro, because the generated SRPM then doesn't match the repository and .spec file name.

nim-nim commented 6 years ago

Yes sure, cased package names are a PITA to use and a PITA to get rid of :( There's no magic bullet once someone used casing in a package name.

It's a pity Fedora guidelines took so long to clarify, other distros made the lowercase step years ago.

decathorpe commented 6 years ago

I agree. sigh Closing this "non-issue".