search

gofed / go-macros

Rpm mechanics for Go packaging
4 stars 7 forks source link

Why remove -git- from %{goname}? #53

Open QuLogic opened 6 years ago

QuLogic commented 6 years ago

I'm packaging go-netrc from git-lfs here and the new macros export %{goname} as golang-github-lfs-netrc. I understand that -go- is removed because it's all over the place in Go package names.

I don't understand why -git- is removed from %{goname} though. Looking at #3, none of them have a -git- in the name. Looking at the full list of Go packages (about double what's in #3), there are only 3 with -git- in the name. So it doesn't look like using -git- in the name is some big problem with Go packages that it needs to be stripped out.

nim-nim commented 6 years ago

-git- was filtered because of https://git.apache.org/

All Apache git urls start and end with git with zero functionnal meaning

The new filtering is more careful to only match such prefixes and suffixes