search

gofed / symbols-extractor

Extractor of symbols from Go based projects
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

incomplete import detection for tests #153

Closed nim-nim closed 5 years ago

nim-nim commented 6 years ago

So I think I finally cracked automation of Go BuildRequires in Fedora rpms (at least the technical POC works, it just needs cleaning up, macrofication and lots of testing)

The big difference between Requires and BuildRequires is that BuildRequires also needs to include the dependencies used by the project unit tests.

Unfortunaly, the first experiments show golist is not detecting those properly (I rebuilt the current snapshot with Go 1.11 just to be sure).

For example, golist --imported --package-path github.com/sirupsen/logrus --skip-self --tests

only outputs github.com/stretchr/testify/assert

for sirupsen logrus, when the terminal_check_notappengine.go test imports golang.org/x/crypto/ssh/terminal

(I had other failures in other packages, this is the simplest case I found)

I hope that can be fixed quickly, otherwise buildrequire automation won't save a lot of packager time

nim-nim commented 5 years ago

migrated to https://pagure.io/golist/issue/9