goferito / node-bing-api

Node.js module for the Bing Search API (Cognitive Services)
MIT License
56 stars 28 forks source link

Add images vertical, gruntfile, test #1

Closed noodlefrenzy closed 10 years ago

noodlefrenzy commented 10 years ago

Hey there,

I'm a MSFT coder in developer evangelism. I wanted to do some work with the Bing API and quickly realized there didn't seem to be an official Node client. Your unofficial client looked the most promising (well-structured, easy to test thanks to the options, light-weight), so I decided to fork it and add the images vertical (which is what I needed), and then add some grunt tasks and a basic test.

I hope this is helpful, let me know if there are other changes you were making or needed and I'll see what I can do to help (unofficially).

P.S. I love your avatar pic :)

goferito commented 10 years ago

Hey! Sorry for the delay. I've been quite sick these days, and completely disconnected.

Thanks a lot. It's always motivating to hear that you are doing things right :) Also thank you for the contribution. Just one question about the naming: Why searchVertical? As far as I understand it, vertical search is a different thing, but I'm not an expert tho. I'd create a new mayor version (since it will break everything) changing the names searchVertical to search, and search to searchWeb, to keep calling things for the proper name. What do you think?

PS. I did it with Gimp. I cannot be more proud about it haha

noodlefrenzy commented 10 years ago

Hey, no worries on the delay, hope you're feeling better!

As for searchVertical, within Bing (and likely in Google as well), verticals are the silo'd search tabs (so e.g. web, image, video, ...). Since it's an internal method anyway, seemed like a reasonable name. I realize it's a different use than e.g. Yelp as a "food vertical search engine" might be, but it's consistent with the big engines' use. Also, I didn't want to do a major breaking change :)

Anyway, thanks for taking my PR, let me know if there's anything else you need help with.