🐛 [Bug]: Missing ContextKey in requestid middleware configuration

[gopkg-dev]

Bug Description

This is my fix:

https://github.com/gofiber/fiber/pull/2731

-   if cfg.ContextKey == "" {
+   if cfg.ContextKey == nil || cfg.ContextKey == "" {
        cfg.ContextKey = ConfigDefault.ContextKey
    }

The fix checks if cfg.ContextKey is either nil or an empty string before assigning the default value ConfigDefault.ContextKey. This ensures that the ContextKey is not missing or empty.

How to Reproduce

package main

import (
    "github.com/gofiber/fiber/v2"
    "github.com/gofiber/fiber/v2/middleware/requestid"
    "github.com/gofiber/fiber/v2/utils"
)
import "log"

func main() {
    app := fiber.New()

    // Steps to reproduce
    app.Use(requestid.New(requestid.Config{
        // ContextKey is currently nil
        Generator: utils.UUID,
    }))

    log.Fatal(app.Listen(":3000"))
}

Expected Behavior

...

Fiber Version

v2.51.0

Code Snippet (optional)

No response

Checklist:

• [X] I agree to follow Fiber's Code of Conduct.
• [X] I have checked for existing issues that describe my problem prior to opening this one.
• [X] I understand that improperly formatted bug reports may be closed without explanation.

[Z3NTL3]

ContextKey is a string i assume and a string can never be nil in Go unless its an interface{}.

So strings in Go can never be nil, but only be a zero value to their concrete type which is an empty string.

Conclusion: Invalid bug mark? plus invalid condition check; unnecessary or operator (slightly more usage on memory (also not fitting innovation of fiber and fasthttp)

@ReneWerner87 correct if its wrong, thnx ^^

[ReneWerner87]

@Z3NTL3 pls check https://github.com/gofiber/fiber/pull/2731#issuecomment-1823236098