efectn commented 1 month ago

Description

Fixes https://github.com/gofiber/fiber/issues/3085

Changes introduced

[ ] Benchmarks: Describe any performance benchmarks and improvements related to the changes.
[ ] Documentation Update: Detail the updates made to the documentation and links to the changed files.
[ ] Changelog/What's New: Include a summary of the additions for the upcoming release notes.
[ ] Migration Guide: If necessary, provide a guide or steps for users to migrate their existing code to accommodate these changes.
[ ] API Alignment with Express: Explain how the changes align with the Express API.
[ ] API Longevity: Discuss the steps taken to ensure that the new or updated APIs are consistent and not prone to breaking changes.
[ ] Examples: Provide examples demonstrating the new features or changes in action.

Type of change

[x] Enhancement (improvement to existing features and functionality)

Checklist

Before you submit your pull request, please make sure you meet these requirements:

[ ] Followed the inspiration of the Express.js framework for new functionalities, making them similar in usage.
[ ] Conducted a self-review of the code and provided comments for complex or critical parts.
[ ] Updated the documentation in the /docs/ directory for Fiber's documentation.
[ ] Added or updated unit tests to validate the effectiveness of the changes or new features.
[ ] Ensured that new and existing unit tests pass locally with the changes.
[ ] Verified that any new dependencies are essential and have been agreed upon by the maintainers/community.
[ ] Aimed for optimal performance with minimal allocations in the new code.
[ ] Provided benchmarks for the new code to analyze and improve upon.

Commit formatting

Please use emojis in commit messages for an easy way to identify the purpose or intention of a commit. Check out the emoji cheatsheet here: CONTRIBUTING.md

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes involve a substantial refactoring of the Client struct and its methods, particularly in how proxy configurations are implemented. The proxyURL field was removed, and the SetProxyURL method now utilizes the fasthttpproxy package for enhanced proxy handling. Additionally, the testing framework has been updated to reflect these changes, ensuring proper validation of proxy functionality during requests.

Changes

Files	Change Summary
`client/client.go`	Removed `proxyURL` field from `Client` struct; updated `SetProxyURL` method to utilize `fasthttpproxy` for setting the proxy.
`client/client_test.go`	Modified `Test_Client_SetProxyURL` to implement a new proxy server using `fasthttp`; updated tests to verify correct proxy behavior and response handling.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Proxy
    participant Server

    Client->>Proxy: SetProxyURL(proxyURL)
    Proxy-->>Client: Proxy set successfully
    Client->>Proxy: Send request
    Proxy->>Server: Forward request
    Server-->>Proxy: Return response
    Proxy-->>Client: Return response

Assessment against linked issues

Objective	Addressed	Explanation
Set proxy should be used when making requests (#3085)	✅
Proxy configuration should be properly validated	❌	No validation logic for proxy URL errors present.

🐇 In the meadow where fibers play,
A proxy hops, brightening the day.
With SetProxyURL, swift and spry,
Now requests soar, like clouds in the sky!
Hooray for the changes, let’s leap and cheer,
For efficient proxies, our vision is clear! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.82%. Comparing base (25e3992) to head (841a100). Report is 6 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3109 +/- ## ========================================== + Coverage 80.77% 80.82% +0.04% ========================================== Files 116 116 Lines 8850 8846 -4 ========================================== + Hits 7149 7150 +1 + Misses 1302 1299 -3 + Partials 399 397 -2 ``` | [Flag](https://app.codecov.io/gh/gofiber/fiber/pull/3109/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gofiber) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/gofiber/fiber/pull/3109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gofiber) | `80.82% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gofiber#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ReneWerner87 commented 1 month ago

Code looks good. @efectn can you fix the lint error

ReneWerner87 commented 1 month ago

Nvm i will do it, its just one word change

ReneWerner87 commented 1 month ago

@efectn something seems to be not thread safe

gofiber / fiber

client: fix SetProxyURL functionality #3109

Description

Changes introduced

Type of change

Checklist

Commit formatting

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Codecov Report