search

gofinance / ib

Pure Go interface to Interactive Brokers IB API
391 stars 121 forks source link

Use environment to pass IB credentials #10

Closed creack closed 9 years ago

uwe commented 9 years ago

The env change looks fine to me. I could not test it (get lots of error messages for "make test" on Mac OS).

I really like the other refactoring with the WriteMap. It is more compact and does not look so tedious.

creack commented 9 years ago

Yeah, there are couple of test failing for a while. I'll try to fix them when I got the time.

creack commented 9 years ago

btw, make test relies on Docker. If you don't want to use Docker, you still can start the tests the old way like travis does.

uwe commented 9 years ago

I love docker and boot2docker is working properly on my machine. If they are failing for a while I can also have a look at them.