search

gofinance / ib

Pure Go interface to Interactive Brokers IB API
386 stars 120 forks source link

Go test not working #24

Open bhanuc opened 7 years ago

bhanuc commented 7 years ago

Here is the output log of the ibgwstart file - https://gist.github.com/bhanuc/29af6844868eb4afc19e5e7a1a09065f It might contain the issue, but I was unable to pinpoint the exact issue. On running go test, I just get a series of 2016/11/02 21:21:44 Waited 5 seconds for reply channel 0xc8200ae240 What is the expected amount of time I am supposed to wait for the test to succeed. Update: I manually entered the username and password on the 5th line of ibgwstart file: Updated log: https://gist.github.com/bhanuc/a417eb70ceaee46a6884315ddc324d62 Updated test log: https://gist.github.com/bhanuc/99564fe1fd46c01d0c66cd4ecfe26b3c

The updated start log shows no error but the test log tells a different story

nothize commented 7 years ago

I think this is related to (https://github.com/gofinance/ib/commit/8a68c49756513d8e13827e87854f372af670a2fb): https://github.com/gofinance/ib/blob/master/manager.go#L128

I debugged and found that one goroutine stuck at https://github.com/gofinance/ib/blob/master/manager.go#L103 waiting for the errors channel forever because errors has been set to nil that reading from a nil channel blocks forever.

Removing errors = nil fixes the test.

nothize commented 7 years ago

Pull Request #26 is submitted to address this issue.

nothize commented 7 years ago

Moved to https://github.com/gofinance/ib/pull/28

nothize commented 6 years ago

PR #28 has been merged to master. @bhanuc Could you re-test from master?