gofr-dev / gofr

An opinionated GoLang framework for accelerated microservice development. Built in support for databases and observability.
https://gofr.dev
Apache License 2.0
3.61k stars 241 forks source link

Fix: Correcting time unit for logs of added http-service #1214

Open coolwednesday opened 1 week ago

coolwednesday commented 1 week ago

Pull Request Template

Description:

Checklist:

Thank you for your contribution!

ccoVeille commented 1 week ago

Please update the PR description

-we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds.
coolwednesday commented 1 week ago

Please update the PR description

-we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

@ccoVeille , I mean what I wrote. The log displays 8 microseconds where in actually gofr calculates it as 8 milliseconds. So we are correcting that, to corrrectly show ....8,000 µs.

ccoVeille commented 5 days ago

Please update the PR description

-we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in Microseconds.
+we use to display as milliseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

@ccoVeille , I mean what I wrote. The log displays 8 microseconds where in actually gofr calculates it as 8 milliseconds. So we are correcting that, to corrrectly show ....8,000 µs.

OK, so I think I'm lost.

Let's reboot.

Your text says:

we use to display as microseconds, which is wrong. Hence corrected the calculations to be done in microseconds.

So it means

The code :

So for me, there is a problem with the text. The code is fine