gofrs / help-requests

request help from the gofrs to maintain a project
49 stars 3 forks source link

ngrok #13

Closed caalberts closed 6 years ago

caalberts commented 6 years ago
theckman commented 6 years ago

It's interesting that you mentioned this, because I wondered if it made sense for us to build something like this from the ground-up. Like an open source implementation of the v2.0 featureset, without relying on any of the older code.

If we adopted this, what do you think we would do? Add a lot more features, or just keep it alive?

antham commented 6 years ago

@theckman at a point if you host a project and maintain it actively, I guess you would need to add features because people would come with good ideas or even with good implementations and it would be hard to say no, it won't make sense.

niaow commented 6 years ago

@theckman I was thinking the same thing! We could implement via a package that did the basic functionality (e.g. ListenAndServeGofrs-ish thing) and command-line client/server applications using this package.

trevorstarick commented 6 years ago

I use Ngrok all the time and would love to help build and maintain a open source derivative!

caalberts commented 6 years ago

The appeal of ngrok to me is that it doesn't add noise to a codebase. It's a versatile tool that boosts dev productivity. Being a CLI, it's compatible with servers written in any language.

In that regard, I would like to see it remain as a CLI tool. How to get there, be it maintaining a fork of v1.0, rebuilding from ground up, is up for discussion.

@trevorstarick feel free to jump in since you use it all the time.

One thing I would like to get clarified, is gofrs objective to maintain Go packages only or any open source projects written in Go?

trevorstarick commented 6 years ago

The goal of the project is to maintain packages and projects, as well as create useful tools to support that goal.

For example, issue number #8 looking into maintaining godef

theckman commented 6 years ago

I think we'll pass on ngrok for now.

I know @trevorstarick is thinking about an open source rewrite that tries to implement all of the ngrok 1.0 features, and to see if there are any features we want to emulate in v2.0. We can raise an issue for that once we come up with a proposal.

Because of v2.0 getting some paid functionality, I think we should avoid making use of ngrok v1 code. With that considered I'm going to close this issue.