gofrs / help-requests

request help from the gofrs to maintain a project
49 stars 3 forks source link

github.com/samuel/go-zookeeper #28

Closed nemith closed 5 months ago

nemith commented 6 years ago

Some public repos i have found: github.com/youtube/vitess/ github.com/sendgrid/go-solr

Browsing through just OSS on github there is Comcast, Cisco

We have been running into a number of bugs around leaked goroutines after a Close() call, some data races, but overall the library doesn't have critical bugs.

https://godoc.org/github.com/samuel/go-zookeeper/zk?importers

adamdecaf commented 6 years ago

+1 to adoption. This is used in vault and prometheus and there are tons of importers.

I've worked with this library a bit, but will help out on the issues PR's.

There seems to be another fork from the network graph. Should we talk to mesosphere?

https://github.com/mesosphere/go-zookeeper

adamdecaf commented 6 years ago

I emailed samuel.

nemith commented 6 years ago

I emailed samuel.

I did as well a little over a month ago and got no response.

adamdecaf commented 6 years ago

I haven't heard anything.

nemith commented 6 years ago

Any plan here? Anything I can help out with?

adamdecaf commented 5 years ago

Dunno. The issues have been pretty quiet.

alxn commented 5 years ago

We have heavy use of this library at Uber and had a couple of PR's merged previously (https://github.com/samuel/go-zookeeper/pull/134, https://github.com/samuel/go-zookeeper/pull/126), we'd like to try and get more things merged (https://github.com/samuel/go-zookeeper/issues/204).

There's a few other wrappers around this library that we could contribute back too (a fake Zookeeper implementation for testing).

I think it would be a good idea to talk to mesosphere (@jdef).

ldez commented 5 months ago

The original repo has been archived and replaced by https://github.com/go-zookeeper/zk.

So I closed this issue.