Closed charlievieth closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
19b5399
) compared to base (ebca088
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Changes seem 👍 on the surface. What does the updated godoc actually look like, @charlievieth? It should be fine since the indented blocks should render well in 1.18 or earlier but it's best to verify before moving forward.
Verified that there is no change in presentation (I think pkg.go.dev might already be applying these changes - all that gofmt
is now doing is trying to make the "semantic meaning" of comments clearer).
The changes here are just the result of gofmt
(as of 1.19) adjusting the code blocks to match the expected format (there is also one change that adds the new build tag format but thats been around for a bit).
See the "Code Blocks" section of doc/comment for more information.
@charlievieth thanks for taking the time to clean up the code here. Would you mind rerunning this against tip master? It looks like the major rework PR yielded some conflicts 👍
@charlievieth thanks for taking the time to clean up the code here. Would you mind rerunning this against tip master? It looks like the major rework PR yielded some conflicts 👍
Done and thanks for the quick review.
Go 1.19 adds doc comments. This commit runs
gofmt
on all the code to update the comments.https://tip.golang.org/doc/go1.19#go-doc