Closed LeonanCarvalho closed 1 year ago
Base: 100.00% // Head: 97.93% // Decreases project coverage by -2.06%
:warning:
Coverage data is based on head (
d0c4244
) compared to base (e1079f3
). Patch coverage: 66.66% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@cameracker It would be great to have your review too :)
@LeonanCarvalho thanks for the submission. What are your thoughts on the decrease of code coverage? Can we get back to 100%?
@LeonanCarvalho thanks for the submission. What are your thoughts on the decrease of code coverage? Can we get back to 100%?
I think we could include tests for nil values since there is an if with default's fallback suggested here https://github.com/gofrs/uuid/pull/111#discussion_r1057721608
Does something flaky on those tests? I ran it on my repo and it passed https://github.com/LeonanCarvalho/uuid/actions/runs/3788789705
I found out that pkg x/tools cover is no longer active and marked as deprecated, that's why the test is falling https://pkg.go.dev/golang.org/x/tools/cmd/cover
I opened another PR to solve this workflow issue https://github.com/gofrs/uuid/pull/115 I would appreciate it if you guys could also take a look at it.
Thanks @LeonanCarvalho !
I rewrote the PR https://github.com/gofrs/uuid/pull/98 authored by @mlesar based on the @theckman comments and recommendations.
Help is wanted to make it happens, this is a very desirable feature especially to generate UUIDv6 with custom timestamps.