Closed charlievieth closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
2a97ddf
) compared to base (e1079f3
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@cameracker @theckman I see you've both recently contributed to and reviewed PRs for this repo. Are you the right people to ping for a review here?
Yep. I may have some time this coming weekend to go over this. Not sure about Cameron.
Thanks the for quick response and no hurries on the review, I just wanted to make sure someone was aware of this PR.
@theckman any chance you have time for a review and if not is there someone else I should ping? Thanks!
Bump, this is a great improvement
@dylan-bourque if everything looks good, could I get another approval from @LeonanCarvalho or any other maintaner?
@dylan-bourque if everything looks good, could I get another approval from @LeonanCarvalho or any other maintaner?
I'm not a maintainer, I'm just an enthusiast, your changes to looks good to me
@cameracker (or anyone else with write access) could I get this reviewed/merged?
@charlievieth I'll give it a look over today with the plan to merge. Thanks so much <3
This commit improves the performance and reduces the number of allocs of most UUID methods and adds a new UUID.Parse() method for parsing string encoded UUIDs.
Parsing string encoded UUIDs is now 2x faster and no longer allocates. The NullUUID MarshalJSON() and UnmarshalJSON() methods have also been improved and no longer call out to json.Unmarshal. The UUID.Format method has been improved for common cases.
Benchmark results: