gogabriel / php-webdriver-bindings

Automatically exported from code.google.com/p/php-webdriver-bindings
0 stars 0 forks source link

Code review request for 1.0 release fixing some open issues #37

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
Branch name: trunk

Purpose of code changes on this branch:

enhancements (missing functionality) and/or bug fixes per issues filed under 
this project that I've assigned to myself as owner. and doing this work in 
preparation for 1.0 release.

When reviewing my code changes, please focus on:

All the changes (code & unit tests), though some notes of interest - 

(1) I have problems using FF profiles even in Java on my dev machine, so can't 
tell if my code & unit test / example added is fully working. Will follow up 
sometime with other machines to test on. In the meantime, would help if you can 
help test whether it works or not, if you've used FF profiles with WebDriver

(2) for my file upload enhancement, the unit test behaves funny, could use help 
verifying functionality (across browsers). I suspect it has something to do 
with PHP (5.3.0 on Windows) and my PHP/web server (QuickPHP). Will try sometime 
later with Apache, and maybe IIS. What I observe is that everything works fine 
until after the upload. On IE9, test passes. On FF and Chrome, the test fails 
because on the PHP server side, it somehow strips the first character of the 
filename we're asserting against but not for IE. Not sure why. The URL (from 
Selenium/WebDriver server) returned back from sendFile() method looks fine 
without first character removed, but once we upload from browser (via the 
follow up sendKeys command), the character is stripped somehow on upload.

After the review, I'll merge this branch into: n/a

Code already in trunk. If required we can revert the code, but I don't think 
there's such a need for that. And we can cut a branch or use a tag for the 1.0 
release or otherwise stick with trunk for that.

Original issue reported on code.google.com by manga...@gmail.com on 9 Jun 2013 at 2:50