Open johanneskoester opened 6 years ago
This seems reasonable to me. Any feedback, @mikecormier @jbelyeu @brentp ?
I believe Mike is actually planning to implement this as soon as he gets some bugs ironed out of the test integration. It does look like a good idea to me for simplification of the structure.
Looks reasonable to me too - great that you're working on it! Happy to test things if there is need! @jbelyeu
Hey guys, I have just thought a bit about the mapper index recipes. I think we should define them like this:
meta.yaml
build.sh
conda_build_config.yaml
The last file (a conda build 3 feature, allows to automatically build for different BWA versions and it would pin the index package to the correct version, such that people can not run into the situation where they have an index that does not match the BWA version.
Finally, if we add
GENOME_BUILD
as a matrix to.travis.yml
, we get builds for all the different genomes for free:This will also help a lot to reduce some redundancy here (because we don't necessary need special recipes for all genomes. In line with this, I also suggest that the tree is extended by
recipes/generic
. Above bwa-index recipe would then sit inrecipes/generic/bwa-index
and automatically yield packages likebwa-index-hg38
, andbwa-index-mm10
, while each is build for both bwa 0.6 and 0.7. All with just one recipe to maintain.