search

gogetssl / whmcs-addon

GOGETSSL WHMCS SSL Addon
MIT License
37 stars 22 forks source link

URGENT - WHMCS v8 - Logs you out #147

Closed qhgh closed 3 years ago

qhgh commented 3 years ago

Describe the bug

  1. On clicking the 'Manage SSL' button from within WHMCS admin on any SSL, then WHMCS logs you out of the system.

  2. On clicking 'Configure SSL' from within the client area it says: 

    The following errors occurred:
Can not fetch Web Server list, plase refresh page or contact support

At the moment we cannot sell any SSL as we cannot configure them as the user or admin.

Suspect this is due to new WHMCS users functionality? https://docs.whmcs.com/Changelog:WHMCS_V8.0

Thanks, C

DennisSkov commented 3 years ago

You're not telling me that you upgraded to WHMCS v8 when this module doesn't support v8 yet? Either disable the SSLCenter module or downgrade WHMCS.

Always test on a development installation first.

vlad-evg commented 3 years ago

Let us check that and compatibility with v8

DennisSkov commented 3 years ago

Let us check that and compatibility with v8

You're gonna be in for a treat... Clients are no longer login-able entities anymore. They rewrote a lot of the login system to be able to introduce users. Our own modules required a fair bit of rewriting to work with WHMCS v8.

qhgh commented 3 years ago

You're not telling me that you upgraded to WHMCS v8 when this module doesn't support v8 yet? Either disable the SSLCenter module or downgrade WHMCS.

Always test on a development installation first.

Noted for next time!

qhgh commented 3 years ago

Let us check that and compatibility with v8

Thank you very much!

vlad-evg commented 3 years ago

We are trying to adopt SSL addon to V8 ASAP

it2ready commented 3 years ago

When can we expect a version compatible with the 8?

DennisSkov commented 3 years ago

Don't rush them. Also, you shouldn't just update to v8. There's a lot of issues with v8 right now - I wouldn't want to upgrade before these have been fixed.

vlad-evg commented 3 years ago

We expect it within 4-5 weeks. We do agree with DennisSkov as v8 is just first release and for sure would have issues

alamaxjashek commented 3 years ago

I have the same error, too. And I am wating for LEI Code Number input field in the SSL and the LEI Code module. Do you have any news about this?

vlad-evg commented 3 years ago

Modules garden rushing and using all resources to update WHMCS to x8 with all other features.

alamaxjashek commented 3 years ago

The module garden zip file is corrupt.. I write to they. Do you have this module files? Can you send me by this way?

Thanks!!

Saludos, Amilcar Angeles.- Consultor Profesional de TI +1-809-657-7751.

Santo Domingo, R.D.

El mié., 14 de oct. de 2020 a la(s) 06:49, Vladislavs Dovoreckis ( notifications@github.com) escribió:

Modules garden rushing and using all resources to update WHMCS to x8 with all other features.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gogetssl/whmcs-addon/issues/147#issuecomment-708291498, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ4MC6W2NNMW7LKHXXAZPSDSKVXYZANCNFSM4R5QAQAA .

vlad-evg commented 3 years ago

We face no issues with ZIP files, they are generated by Github. Please download it from here: https://github.com/gogetssl/whmcs-addon/releases/tag/v2.4.10

Again, those files do not support v8 yet

ordubilisim commented 3 years ago

Hi whmcs v8.0.3 not working

vlad-evg commented 3 years ago

Hi,

Yes, we expect to release SSL addon on 27-28 October.

qhgh commented 3 years ago

Hi,

Yes, we expect to release SSL addon on 27-28 October.

Excellent news! Thanks 👍

vlad-evg commented 3 years ago

WHMCS x8 Released

qhgh commented 3 years ago

Thanks for this!

I have tested but am unable to Manage SSL with a OOps Error. It seems this is because the SSL was not created, but there is no Create SSL button?

manage-ssl oops-page-not-found cannot-create

Thanks for any help! C

vlad-evg commented 3 years ago

Yeap, that is fixed already https://github.com/gogetssl/whmcs-addon/releases/tag/v2.5.0b

sorry, WHMCS x8 is still unstable and we face issues and can't release a super stable release too

qhgh commented 3 years ago

Yeap, that is fixed already https://github.com/gogetssl/whmcs-addon/releases/tag/v2.5.0b

sorry, WHMCS x8 is still unstable and we face issues and can't release a super stable release too

Thanks for the fix and good work :)

qhgh commented 3 years ago

Okay, so we are now importing all the manual orders we made, but it seems it won't show the correct price after import?

Here we see the manual SSL we created £36 and the imported one showing £6.49

imported-price-wrong-g

Here we see the correct price is set within the SSL in WHMCS:

imported-order-whmcs-price-correct-g

But still, it shows £6.49 and not £36?

Any ideas?

Thanks, C

vlad-evg commented 3 years ago

the modules Garden replied:

"I have checked it many times, the module in the import it does not issue invoices and does not set the price. The price is as shown in the product settings."

:/

qhgh commented 3 years ago

Hi Vlad,

I've checked again just now and you are right, no invoice or emails are sent now 👍

However, I can see the issue is with One Time vs Annual Billing Cycles.

If we sent an imported SSL to Annual, it shows the price set on the WHMCS product page. When we set it back to the correct Onetime, it shows the wrong value. This wrong value is not set anywhere on the SSL product page.

Can you please help on this?

It's only affecting imported SSL, so it must be an issue there.

Thanks again! C

vlad-evg commented 3 years ago

Thank you for your comment, checking

vlad-evg commented 3 years ago

MG's reply:

Sorry, I still don't understand where the issue is, the prices in the screenshots are the same.

Let me describe how the import works

  1. The module gets data about the certificate
  2. The module determines the billing cycle of the certificate
  3. The module creates an order
  4. The module does not set the price for the product
  5. When creating a new order, only the billing cycle is given and on this basis WHMCS sets the price for the product

As for the price difference between import and standard order, it may result from the commission. The commission is not taken into account when importing.

qhgh commented 3 years ago

Hi Vlad,

Thanks for the reply.

the prices in the screenshots are the same.

They are not the same. One says £6.49 and one says £36. I've attached the screenshot again:

importedvsmanually

Both prices are set to £36 in the SSL product page within WHMCS.

new order:

importedvsnew-new

imported order:

importedvsnew-imported

As we can see, both SSL are set to £36. But, the imported SSL shows £6.49 in WHMCS and to the customer.

PS we do not use commission settings etc. and this only happens on imported SSL.

Does this help to clarify the issue? Are you saying this is a WHMCS issue? I'm happy to raise this with them, but as it only happens to imported SSL, I think its a GGSSL issue?

Thanks, C

vlad-evg commented 3 years ago

Issue solved with release 2.0.5d