gogetssl / whmcs-addon

GOGETSSL WHMCS SSL Addon
MIT License
37 stars 22 forks source link

Wildcard SAN input field is shown twice. #209

Closed MnM202 closed 1 year ago

MnM202 commented 1 year ago

Describe the bug The wildcard san input field is shown twice when trying to configure a mult-domain flex SSL certificate.

To Reproduce Steps to reproduce the behavior:

  1. Create a GoGetSSL@ Multi-Domain SSL certificate
  2. Generate pricing for SAN.
  3. Generate pricing for wildcard SANs.
  4. Fill in pricing for both
  5. Order the product in WHMCS
  6. Add a few additional SANs of both Single and Wildcard type.
  7. Notice a double input field for wildcard SANs in the interface. Only the bottom one works.

Expected behavior I expect to see only one input field for wildcard sans in flex certificates that have both SANs and Wildcard SANs.

Screenshots GoGetSSL Mult-Domain SSL SAN Pricing WildSAN Pricing

Here you can see the wildcard sans having two input fields. Only the bottom one works. Wildcard SANs displayed twice

vlad-evg commented 1 year ago

Developers are checking it now

vlad-evg commented 1 year ago

Can you please try the latest release? https://github.com/gogetssl/whmcs-addon/releases/tag/v2.7.5a

MnM202 commented 1 year ago

Hi Vlad,

Thank you for coming back to me. Much appreciated.

The new version looks much improved.

While testing, i did notice three additional issues that seem to be in 2.7.5 as well. I don't think they are related to your current code changes.

Do you wish for me to raise these as separate issues? Or shall we proceed testing from here.

After the validation step on the first certificate reissue the following error is displayed when adding an additional wildcard SAN. CountOfWildcardSANsExceeded

In the GoGetSSL website only one wildcard san is added to the certificate. ( i ordered the product with two additional wildcard sans ) OnlyOneWildcardSan

On the second reissue some sans are lost and the ones that remain are displayed , separated in the SAN input field: SANandWildcardMergedTogether

It looks like the amount of single domain san items in the certificate increases with each reissue: IncreasedDomainItems

vlad-evg commented 1 year ago

Developers are checking that too. Thank you for the help

MnM202 commented 1 year ago

Small update. Version 2.7.6 has now been released.

I still experience the following issues:

vlad-evg commented 1 year ago

Please try 2.7.6, it should solve the issue https://github.com/gogetssl/whmcs-addon/releases/tag/v2.7.6

MnM202 commented 1 year ago

Hi Vlad,

The module is better, but there is still an issue left: 1) Order an SSL certificate ( this will work fine and the SAN count in gogetssl is correct ). 2) Reissue the ssl certificate and modify it. 3) Wait until it gets issued. ( the san count is now no longer correct but the certificate will get issues with the correct SANs ) 4) Reissue the ssl certificate again. ( Now the domains will show as a , seperated list in the SAN domains field. )

I made sure to clean the template files as well. But i still get this issue in the latest 2.7.6 module.

vlad-evg commented 1 year ago

Please try 2.7.6a https://github.com/gogetssl/whmcs-addon/releases/tag/v2.7.6a

MnM202 commented 1 year ago

Hi Vlad,

It is getting closer. But not completely fixed yet for me.

1) On the first reissue of the certificate i still see the SAN/Wildcard SAN count increase on the gogetssl.com side of things.

2) On the second reissue i now see the following in SANs: domain1.com,domain2.com And the following in the wildcard SANs box: *.domain3.com,*.domain4.com

So the SAN types are split up now. But the individual domains are still , separated.

vlad-evg commented 1 year ago

https://github.com/gogetssl/whmcs-addon/releases/tag/v2.7.7

Now should be fine :))

MnM202 commented 1 year ago

Hi Vlad,

Thank you for sticking with me on this issue.

I gave it another try. We're getting a bit closer again, but still not completely perfect.

1) On the initial request the certificate is issued correctly and 2) The first time i reissue the certificate it worked fine. ( and the amount of sans / wildcard sans seems to be correct now ) 3) On the second renewal the san and wildcard san fields are now both empty. ( instead of split , separated like the previous time )

vlad-evg commented 1 year ago

Hope that would do all you need (

https://github.com/gogetssl/whmcs-addon/releases/tag/v2.7.7a

vlad-evg commented 1 year ago

Can you please check compare option on GIT? https://www.screencast.com/t/MkmCGqBPWyk

MnM202 commented 1 year ago

Hi Vlad,

Things are coming together now. I am able to reissue for an unlimited amount of times now and the domains are always in the correct spot. So this makes the module usable from a user perspective.

During my renewal i did manage to get into a situation where the the gogetssl.com website displays the wildcard san count incorrectly. ( one additional san got added on renewal ) but this did not effect the reissue procedure. But i have not found a clear way to reproduce that one yet.

All in all the module is now in a much better shape for me.

vlad-evg commented 1 year ago

Let us know if the problem will be reproduced again!