gogf / gf

A powerful framework for faster, easier, and more efficient project development.
https://goframe.org
MIT License
11.81k stars 1.61k forks source link

There is a deadlock in gcache #3577

Closed mijjjj closed 6 months ago

mijjjj commented 7 months ago

Go version

go1.22.1

GoFrame version

2.7.0

Can this bug be reproduced with the latest release?

Option Yes

What did you do?

gcache.GetOrSetFuncLock

What did you see happen?

使用gcache.GetOrSetFuncLock会死锁

What did you expect to see?

正常运行

wln32 commented 7 months ago

你的代码是什么呢,发出来看看

Issues-translate-bot commented 7 months ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


What is your code? Send it and take a look.

mijjjj commented 7 months ago

image 很正常的语句,使用的是内存缓存,数据库使用时sqlite,调试发现函数有正常执行到,但是返回后就会出现死锁,使用GetOrSetFunc正常使用

wln32 commented 7 months ago

@gqcn @mijjjj 我复现了死锁的情况,以下是代码

// 创建表
create table issue3577(
    id INT PRIMARY KEY     NOT NULL,
    name           TEXT    NOT NULL,
    age            INT     NOT NULL
)
// 插入一条数据
insert into issue3577 values(1,'wln',28);

type Issue3577 struct {
    Id   int    `orm:"id"`
    Name string `orm:"name"`
    Age  int    `orm:"age"`
}

func init(){
       gdb.AddConfigNode("sqlite", gdb.ConfigNode{
        Link: "sqlite::@file(/testdb.sqlite3)",
    })
}

func Test_issue3577(t *testing.T) {
    ctx := context.TODO()
    sqlite := g.DB("sqlite")

    key := "isssue3577"
    t.Log("连接sqlite成功,开始查询")
    v, err := gcache.GetOrSetFuncLock(ctx, key, func(ctx context.Context) (value interface{}, err error) {
        return test_issue3557_getone(ctx, sqlite)
    }, 0)
    t.Log("查询结束")
    if err != nil {
        t.Fatal(err)
    }
    t.Log("val=", v.Interface())
}

func test_issue3557_getone(_ context.Context, db gdb.DB) (val any, err error) {
    res, err := db.Model("issue3577").One()
    if err != nil {
        return nil, err
    }
    data := Issue3577{}
    err = res.Struct(&data)
    return data, err
}

运行命令 go test -timeout 30s -run ^Test_issue3577$ 运行上述代码,会死锁,可以自行查询打印的堆栈情况,

问题出现在当执行gcache.GetOrSetFuncLock , 内部会调用(d adapterMemoryData) SetWithLock,这个函数一开始就直接mu.Lock 然后在调用回调函数test_issue3557_getone的时候, 内部会调用(m softTimeMaintainer) getSoftFieldNameAndType,文件路径: gf/database/gdb/gdb_model_soft_time.go:218 再往里面最终会调用(d *adapterMemoryData) Get,文件路径: gf/os/gcache/gcache_adapter_memory_data.go:145 这个函数一开始就调用了mu.RLock,然后上面一开始调用的mu.Lock还没有解锁,所以就造成了死锁

wln32 commented 7 months ago

图片在上面发不出来,在这里发

2222

wln32 commented 7 months ago

pr #3579 可以解决此bug

Issues-translate-bot commented 7 months ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


3579 can solve this bug

mijjjj commented 7 months ago

嗯嗯,我就是切换到默认的了

mijjjj commented 7 months ago

只能先这样用了

Issues-translate-bot commented 7 months ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Yeah, okay, I just switched to the default one.

Issues-translate-bot commented 7 months ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


This is the only way to use it first

gqcn commented 6 months ago

Let me handle this.

gqcn commented 6 months ago

https://github.com/gogf/gf/pull/3585