search

goggle / script.module.srgssr

Kodi script for SRG SSR related Kodi plugins.
GNU General Public License v3.0
0 stars 8 forks source link

Subtitles cannot be disabled by settings #31

Open alphanet72 opened 1 week ago

alphanet72 commented 1 week ago

Apparently, subtitles are always on, but can be disabled through the telecommand with the [...] key.

goggle commented 6 days ago

So my suggestion to resolve this issue is to remove that option from the plugin's settings. I think it's not the plugins job to let the user decide if subtitles should be retrieved, because this can be turned of or be disabled elsewhere in Kodi. So if a plugin supports retrieving subtitles, it should always attach them to the video and the user can always opt-out without needing to specify that in the plugin's settings.

By the way, I'm also thinking about removing the option Prefer HD quality, I don't really see the benefits to have this option anymore.

alphanet72 commented 6 days ago

Hello,

On Thu, Oct 03, 2024 at 06:39:52PM -0700, Alexander Seiler wrote:

So my suggestion to resolve this issue is to remove that option from the plugin's settings. I think it's not the plugins job to let the user decide if subtitles should be retrieved, because this can be turned of or be disabled elsewhere in Kodi. So if a plugin supports retrieving subtitles, it should always attach them to the video and the user can always opt-out without needing to specify that in the plugin's settings.

Yes.

By the way, I'm also thinking about removing the option Prefer HD quality, I don't really see the benefits to have this option anymore.

OK, I don't see the impact that that could do, I don't think I used that option.

Have a nice day.