New sqlite version breaks build

[zx2c4]

The latest version fails to build:

[ 65%] Building CXX object src/CMakeFiles/gogglesmm.dir/GMFontDialog.cpp.o
cd /var/tmp/portage/media-sound/gogglesmm-1.1.8/work/gogglesmm-1.1.8_build/src && /usr/lib64/ccache/bin/x86_64-pc-linux-gnu-g++ -Dgogglesmm_EXPORTS -I/usr/include/fox-1.7 -I/usr/include/taglib -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/var/tmp/portage/media-sound/gogglesmm-1.1.8/work/gogglesmm-1.1.8/gap/include   -DNDEBUG -march=native -fomit-frame-pointer -O2 -pipe -fvisibility=hidden -fvisibility-inlines-hidden   -Wall -Wextra -Wformat=2 -Wfatal-errors -std=gnu++11 -o CMakeFiles/gogglesmm.dir/GMFontDialog.cpp.o -c /var/tmp/portage/media-sound/gogglesmm-1.1.8/work/gogglesmm-1.1.8/src/GMFontDialog.cpp
In file included from /var/tmp/portage/media-sound/gogglesmm-1.1.8/work/gogglesmm-1.1.8/src/GMDatabase.cpp:21:0:
/usr/include/sqlite3.h:3712:16: error: using typedef-name ‘sqlite3_value’ after ‘struct’
 typedef struct sqlite3_value sqlite3_value;
                ^
compilation terminated due to -Wfatal-errors.
make[2]: *** [src/CMakeFiles/gogglesmm.dir/build.make:343: src/CMakeFiles/gogglesmm.dir/GMDatabase.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from /var/tmp/portage/media-sound/gogglesmm-1.1.8/work/gogglesmm-1.1.8/src/GMDatabaseSource.cpp:55:0:
/usr/include/sqlite3.h:3712:16: error: using typedef-name ‘sqlite3_value’ after ‘struct’
 typedef struct sqlite3_value sqlite3_value;
                ^
compilation terminated due to -Wfatal-errors.

[gogglesguy]

Thanks for the report. Please try building from the stable branch. Just committed some fixes a few days ago that should fix the build issue.

[zx2c4]

It builds well now, with only one warning:

/tmp/gogglesmm/gap/plugins/ap_mp4.cpp: In member function ‘FX::FXbool ap::MP4Reader::atom_parse(FX::FXlong)’:
/tmp/gogglesmm/gap/plugins/ap_mp4.cpp:1193:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
                  if(!ok) return false;
                  ^~
/tmp/gogglesmm/gap/plugins/ap_mp4.cpp:1195:7: note: here
       case MDIA:
       ^~~~

If you make a new release with these fixes, I'll bump the Gentoo ebuild.

[gogglesguy]

Thanks. Will try to get a release out this weekend.

[gogglesguy]

Fixed in 1.1.9

[zx2c4]

Pushed to Gentoo: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27d9c706a3ef98c44b93dd6f32fc8592f7fa4f27

Though the system does give one warning:

 * QA Notice: This package installs one or more .desktop files that do not
 * pass validation.
 * 
 *      /usr/share/applications/gogglesmm.desktop: warning: value "Application;AudioVideo;Audio;Player;" for key "Categories" in group "Desktop Entry" contains a deprecated value "Application"
 * 

[gogglesguy]

Thanks