Csound patch maintenance

[gogins]

This issue requires a general cleanup of the csound-extended/silencio/patches directory.

• [x] Create a patch test script for effects patches.
• [x] Finish FaustGreyholeReverb. Looks correct, but Faust doesn't compile it.
• [x] Finish FaustJPReverb. Looks correct, but Faust doesn't compile it.
• [x] Ensure that all patches use chnexportfor control channels.
• [x] Ensure that all patches use ftgen not ftgenonce.
• [x] Ensure that all patches are roughly the same loudness.
• [x] Ensure that all patches produce notes, reflecting back into tunable domain if necessary.
• [x] Ensure that all instrument patches have spatialization code.
• [x] Remove any patches that are not usable.
• [x] Ensure that note duration works for all use cases: score driven, MIDI driven, and note on/note off. Does this simply mean xtratim for attack + release?

[gogins]

Not all of these have controllable pitch, some are textures or single unpitched events.

• [x] BanchoffKleinBottle.inc
• [x] BandedWG.inc
• [x] BarModel.inc
• [x] BassModel.inc
• [x] Blower.inc
• [x] Bower.inc
• [x] Buzzer.inc
• [x] Cascone_ClickyFilterSweep.inc
• [x] Cascone_FMReverseEnv.inc
• [x] Cascone_RissetCascadeHarmonics.inc
• [x] Cascone_SampleAndHold.inc
• [x] Cascone_Sine.inc
• [x] Cascone_ThreeBranch.inc
• [x] Cascone_Water.inc
• [x] ChebyshevMelody.inc
• [x] ChebyshevPoly.inc
• [x] Compressor.inc
• [x] CostelloGong.inc. Couldn't control levels, removed.
• [x] DelayedPlucked.inc. Some clicks.
• [x] Droner.inc
• [x] FaustBrass.inc. Hard to tune parameters for pitch, only a few notes work with default parameters.
• [x] FaustBubble.inc
• [x] FaustChurchBell.inc
• [x] FaustControllableNonPhysicalString.inc. Removed.
• [x] FaustDjembe.inc
• [x] FaustGermanBell.inc
• [x] FaustGreyholeReverb.inc. Looks correct, but Faust doesn't compile it.
• [x] FaustJPReverb.inc. Looks correct, but Faust doesn't compile it.
• [x] FaustModularBody.inc
• [x] FaustNLFfm.inc
• [x] FaustRain.inc
• [x] FaustSimpleFM2.inc
• [x] FaustTurenas.inc
• [x] FaustWind.inc
• [x] FilteredSines.inc
• [x] FluidAudio.inc
• [x] FluidsynthNote.inc
• [x] FluidsynthOut.inc
• [x] FMBell.inc
• [x] FM_Clang_Controls.inc
• [x] FM_Clang.inc
• [x] FM_Clang_Preset.inc
• [x] FMDroner.inc
• [x] FMModerate2.inc
• [x] FMModerate.inc
• [x] FMModulatedChorus.inc
• [x] FMWaterBell.inc
• [x] Guitar.inc
• [x] Harpsichord.inc
• [x] HeavyMetal.inc
• [x] Internals.inc
• [x] JackAudio.inc
• [x] JackNote.inc
• [x] KarplusStrong3.inc. Not working, nothing extra, removed.
• [x] LeftReverberator.inc
• [x] LivingstonGuitar.inc. Excessive noise, limited range, fix later?
• [x] MasterOutput.inc
• [x] Melody.inc
• [x] MonoReverberator.inc. Redundant, removed.
• [x] Mverb2020.inc
• [x] MVerb.inc. As good as, if not better than, the best.
• [x] Night2.inc
• [x] OrganNoteOrganteq.inc
• [x] OrganOutOrgantec.inc
• [x] ParametricEQ.inc
• [x] Phaser.inc
• [x] PhysicalModel2.inc. Don't see how to fix, removed.
• [x] PianoNoteFluidsynth.inc
• [x] PianoNotePianoteq.inc
• [x] PianoOutFluidsynth.inc
• [x] PianoOutPianoteq.inc
• [x] Plucked.inc
• [x] PulseWidthModulation.inc
• [x] RampSaw.inc, too many problems. Removed.
• [x] Reverb1.inc
• [x] Reverb2.inc
• [x] Reverberator.inc
• [x] ReverbSC.inc
• [x] Rhodes.inc
• [x] RightReverberator.inc
• [x] Shiner.inc
• [x] SolinaChorus.inc
• [x] Soundfile.inc
• [x] Spatialize1.inc
• [x] Spatialize2.inc
• [x] Spatialize.inc
• [x] STKBeeThree.inc
• [x] STKBowed.inc
• [x] STKPlucked.inc
• [x] StringPad.inc
• [x] Sweeper.inc
• [x] Template.inc
• [x] TerrainMappedBass.inc
• [x] TerrainMappedLead.inc
• [x] TerrainMappedPulsar.inc
• [x] TerrainMappedSquarish.inc
• [x] ToneWheelOrgan.inc
• [x] TubularBell.inc
• [x] WaveTerrain.inc. Not sure this is working, sounds clicky and buzzy.
• [x] WGPluck.inc
• [x] Xing.inc
• [x] YiString.inc
• [x] ZakianFlute.inc

[gogins]

Closing this.

There may be a separate issue with Faust opcodes that take inputs.

However, I think the problem is the use of an "environment" in the reverbs.lib.