GitHub Actions builds failing for Ubuntu and Mac OS

gogins / csound-vst3-opcodes

The "vst3" opcodes enable Csound to host VST3 plugin instruments and effects.

GNU General Public License v3.0

5 stars 2 forks source link

GitHub Actions builds failing for Ubuntu and Mac OS #6

Closed gogins closed 2 years ago

gogins commented 2 years ago

[x] Update C++ standard to c++17.
[x] Explicitly include fstring.h.
[x] Fix "error: this file needs to be compiled with automatic reference counting enabled". I'm trying:
```
target_compile_options(vst3_plugins PRIVATE "-fobjc-arc")
```
Not needed. Problem was using the vstgui4 submodule with an incorrect commit.

gogins commented 2 years ago

There is a real problem. I have this:

https://github.com/steinbergmedia/vstgui/blob/develop/vstgui/lib/events.h

But events.h doesn't show up in the vstgui4 submodule for vst3sdk. If I browse the submodule I don't find it. I get:

https://github.com/steinbergmedia/vstgui/tree/6c48e17c174abaf2f1dc8ae41e5fab70599eca6c/vstgui

I think I probably just need to use the specific commit with which the submodule was created. I will try that now.

No, I need to pull and commit the vst3sdk submodule at its current version, but leave the submodules of that submodule as it has them.

gogins commented 2 years ago

Updated the submodules and rebuilt successfully on my Ubuntu machine. We'll see how it goes on the GitHub runners. Ubuntu runner seems OK, but Mac OS is still a problem.

https://github.com/steinbergmedia/vstgui/tree/ff769d70900af2ff31685006dd454dfc211bdf61/vstgui/lib has events.h.

gogins commented 2 years ago

This was the fix. Change:

git submodule update --init --recursive --remote

to:

git submodule update --init --recursive