search

gogo / grpc-example

An example of using Go gRPC and tools from the greater gRPC ecosystem together with the GoGo Protobuf Project.
Other
454 stars 88 forks source link

Show the use of proper gogo/googleapi types with status. #10

Closed johanbrandhorst closed 6 years ago

johanbrandhorst commented 6 years ago

This avoids the use of google.golang.org/genproto package types (except for the mandatory status type).

johanbrandhorst commented 6 years ago

I'm going to remove the manual vendor changes and wait with merging this until upstream (https://github.com/grpc/grpc-go/pull/1927) has been merged (or rejected :sob:).

awalterschulze commented 6 years ago

Sounds like a plan :)

On Sun, 18 Mar 2018 at 16:06 Johan Brandhorst notifications@github.com wrote:

I'm going to remove the manual vendor changes and wait with merging this until upstream (grpc/grpc-go#1927 https://github.com/grpc/grpc-go/pull/1927) has been merged (or rejected 😭).

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/gogo/grpc-example/pull/10#issuecomment-374006467, or mute the thread https://github.com/notifications/unsubscribe-auth/ABvsLUSM8jRNZlsiWaP5YvjWAgC1vhO2ks5tfngLgaJpZM4Su5sh .

johanbrandhorst commented 6 years ago

Updated in anticipation of grpc/grpc-go#1927. Will just need setting the Gopkg.toml back then we can merge.

awalterschulze commented 6 years ago

Ooo wow. This looks great. I hope 1927 goes through. Great work.

johanbrandhorst commented 6 years ago

I've update this with the new gRPC version, and gogo/status, and everything seems to work alright.